]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Kill running processes on upgrades/uninstalls
authorBen Kaduk <kaduk@mit.edu>
Thu, 16 Aug 2012 20:03:48 +0000 (16:03 -0400)
committerTom Yu <tlyu@mit.edu>
Wed, 29 Aug 2012 23:17:17 +0000 (19:17 -0400)
The InstallValidate action of the windows installer will bring up
a dialog informing us that some currently running processes must
be terminated before installation may proceed, and offers to do so,
but does not actually kill the processes.  We have our own code to
kill running processes which did not execute, for two reasons:
it was sequenced after InstallValidate, and we did not have a current
list of processes to look for.

Add the right processes to look for and kill, and use our own
process-killing code since it actually works.

(cherry picked from commit 79e5540860d077693e70b340db4d69d5e15107b7)

ticket: 7343
status: resolved

src/windows/installer/wix/kfw.wxs

index 20a70e5ed798bb8a12706655a8eabd20f45de163..d00c6e88e8b4f80568630cab32bce8e1912cda1b 100755 (executable)
        <!-- Installation Sequences -->
        <AdminExecuteSequence />
         <InstallExecuteSequence>
-       <Custom Action="KillRunningProcesses" After="InstallValidate"/>
-       <RemoveExistingProducts After="KillRunningProcesses">(Not Installed) And (UPGRADEPISMERE Or UPGRADEKFW Or UPGRADEKFW64)</RemoveExistingProducts>
+       <Custom Action="ListRunningProcesses" Before="KillRunningProcesses" />
+       <Custom Action="KillRunningProcesses" Before="InstallValidate"/>
+       <RemoveExistingProducts After="InstallValidate">(Not Installed) And (UPGRADEPISMERE Or UPGRADEKFW Or UPGRADEKFW64)</RemoveExistingProducts>
        <Custom Action="RenameKrb5Ini_Cmd" Before="RenameKrb5Ini"/>
        <Custom Action="RenameKrb5Ini" Before="InstallFinalize">SYSTEMKRB5INI &lt;&gt; ""</Custom>
        <!-- When running with a UI, CCP_Success property is not passed down to the server. -->
                 <Data Column="Image">krbcc32s.exe</Data>
                 <Data Column="Desc">Kerberos Credential Cache</Data>
             </Row>
+            <Row>
+                <Data Column="Id">kpKrbcc64</Data>
+                <Data Column="Image">krbcc64s.exe</Data>
+                <Data Column="Desc">Kerberos Credential Cache</Data>
+            </Row>
             <Row>
                 <Data Column="Id">kpK95</Data>
                 <Data Column="Image">k95.exe</Data>
                 <Data Column="Image">afscreds.exe</Data>
                 <Data Column="Desc">AFS Credentials Manager</Data>
             </Row>
+            <Row>
+                <Data Column="Id">kccapiserver</Data>
+                <Data Column="Image">ccapiserver.exe</Data>
+                <Data Column="Desc">Credentials Cache API Server</Data>
+            </Row>
+            <Row>
+                <Data Column="Id">kMITKerberos</Data>
+                <Data Column="Image">MIT Kerberos.exe</Data>
+                <Data Column="Desc">MIT Kerberos Ticket Manager</Data>
+            </Row>
         </CustomTable>
     </Product>
 </Wix>