dns_ssu_external_match was called with an address for UDP

Addresses are only supposed to be passed to dns_ssu_external_match
when the connection comes from TCP or another mechanism which verifies
the source address.  This has been fixed.

diff --git a/lib/dns/ssu.c b/lib/dns/ssu.c
index 321fdacaab09133d630613b26ceb336e402859be..4a9c1dc59ae4c5c66b2c528f13768ce7a7b80023 100644 (file)
--- a/lib/dns/ssu.c
+++ b/lib/dns/ssu.c
@@ -893,8 +893,8 @@ dns_ssutable_checkrules(dns_ssutable_t *table, const dns_name_t *signer,
                        break;
                case dns_ssumatchtype_external:
                        if (!dns_ssu_external_match(rule->identity, signer,
-                                                   name, addr, type, key,
-                                                   table->mctx))
+                                                   name, tcp ? addr : NULL,
+                                                   type, key, table->mctx))
                        {
                                if (logit) {
                                        isc_log_write(