]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: at91: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 24 Apr 2025 08:35:32 +0000 (10:35 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 29 Apr 2025 08:34:45 +0000 (10:34 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/20250424-gpiochip-set-rv-pinctrl-part2-v1-9-504f91120b99@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91.c

index 93ab277d9943cff3a0b771f3e997594cb144826c..442dd8c80b650c4d42adfc07d8898aa946c302ae 100644 (file)
@@ -1449,18 +1449,19 @@ static int at91_gpio_get(struct gpio_chip *chip, unsigned offset)
        return (pdsr & mask) != 0;
 }
 
-static void at91_gpio_set(struct gpio_chip *chip, unsigned offset,
-                               int val)
+static int at91_gpio_set(struct gpio_chip *chip, unsigned int offset, int val)
 {
        struct at91_gpio_chip *at91_gpio = gpiochip_get_data(chip);
        void __iomem *pio = at91_gpio->regbase;
        unsigned mask = 1 << offset;
 
        writel_relaxed(mask, pio + (val ? PIO_SODR : PIO_CODR));
+
+       return 0;
 }
 
-static void at91_gpio_set_multiple(struct gpio_chip *chip,
-                                     unsigned long *mask, unsigned long *bits)
+static int at91_gpio_set_multiple(struct gpio_chip *chip,
+                                 unsigned long *mask, unsigned long *bits)
 {
        struct at91_gpio_chip *at91_gpio = gpiochip_get_data(chip);
        void __iomem *pio = at91_gpio->regbase;
@@ -1472,6 +1473,8 @@ static void at91_gpio_set_multiple(struct gpio_chip *chip,
 
        writel_relaxed(set_mask, pio + PIO_SODR);
        writel_relaxed(clear_mask, pio + PIO_CODR);
+
+       return 0;
 }
 
 static int at91_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
@@ -1798,8 +1801,8 @@ static const struct gpio_chip at91_gpio_template = {
        .direction_input        = at91_gpio_direction_input,
        .get                    = at91_gpio_get,
        .direction_output       = at91_gpio_direction_output,
-       .set                    = at91_gpio_set,
-       .set_multiple           = at91_gpio_set_multiple,
+       .set_rv                 = at91_gpio_set,
+       .set_multiple_rv        = at91_gpio_set_multiple,
        .dbg_show               = at91_gpio_dbg_show,
        .can_sleep              = false,
        .ngpio                  = MAX_NB_GPIO_PER_BANK,