]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
lib/utils kr_ranked_rrarray_add(): clarify merging RRs
authorVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 21 Nov 2019 14:28:47 +0000 (15:28 +0100)
committerTomas Krizek <tomas.krizek@nic.cz>
Wed, 4 Dec 2019 13:31:51 +0000 (14:31 +0100)
lib/utils.c

index cb15f4637d9d31be5e2218ba72ef727d5dbc4faa..140e8ecb33017386d7346fbe3cc2e7c9a482d35e 100644 (file)
@@ -711,6 +711,9 @@ int kr_ranked_rrarray_add(ranked_rr_array_t *array, const knot_rrset_t *rr,
                }
                if (stashed->qry_uid != qry_uid) {
                        break;
+                       /* We do not guarantee merging RRs "across" any point that switched
+                        * to processing a different upstream packet (i.e. qry_uid).
+                        * In particular, iterator never returns KR_STATE_YIELD. */
                }
                if (!rrsets_match(stashed->rr, rr)) {
                        continue;