]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: light: vcnl4000: remove error messages for trigger and irq
authorErikas Bitovtas <xerikasxx@gmail.com>
Fri, 20 Mar 2026 16:45:40 +0000 (18:45 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 21 Mar 2026 12:40:30 +0000 (12:40 +0000)
The error code is available in the log after return. In our case,
attaching a triggered buffer can only fail if we are out of memory, as
no other buffer is being attached. Remove duplicate error messages to
reduce noise in dmesg.

Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/vcnl4000.c

index cd7e6ee42cc5a6db53fca2b71966a48a8eff76ba..76aee16d479b49e81ff7506efc5b92e2490441f5 100644 (file)
@@ -2033,11 +2033,8 @@ static int vcnl4000_probe(struct i2c_client *client)
                                                      NULL,
                                                      data->chip_spec->trig_buffer_func,
                                                      data->chip_spec->buffer_setup_ops);
-               if (ret < 0) {
-                       dev_err(&client->dev,
-                               "unable to setup iio triggered buffer\n");
+               if (ret < 0)
                        return ret;
-               }
        }
 
        if (client->irq && data->chip_spec->irq_thread) {
@@ -2047,10 +2044,8 @@ static int vcnl4000_probe(struct i2c_client *client)
                                                IRQF_ONESHOT,
                                                "vcnl4000_irq",
                                                indio_dev);
-               if (ret < 0) {
-                       dev_err(&client->dev, "irq request failed\n");
+               if (ret < 0)
                        return ret;
-               }
 
                ret = vcnl4010_probe_trigger(indio_dev);
                if (ret < 0)