]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mlxbf-bootctl: use sysfs_emit_at() in secure_boot_fuse_state_show()
authorDavid Thompson <davthompson@nvidia.com>
Mon, 7 Apr 2025 13:25:58 +0000 (13:25 +0000)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 11 Apr 2025 09:56:52 +0000 (12:56 +0300)
A warning is seen when running the latest kernel on a BlueField SOC:
[251.512704] ------------[ cut here ]------------
[251.512711] invalid sysfs_emit: buf:0000000003aa32ae
[251.512720] WARNING: CPU: 1 PID: 705264 at fs/sysfs/file.c:767 sysfs_emit+0xac/0xc8

The warning is triggered because the mlxbf-bootctl driver invokes
"sysfs_emit()" with a buffer pointer that is not aligned to the
start of the page. The driver should instead use "sysfs_emit_at()"
to support non-zero offsets into the destination buffer.

Fixes: 9886f575de5a ("platform/mellanox: mlxbf-bootctl: use sysfs_emit() instead of sprintf()")
Signed-off-by: David Thompson <davthompson@nvidia.com>
Link: https://lore.kernel.org/r/20250407132558.2418719-1-davthompson@nvidia.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/mellanox/mlxbf-bootctl.c

index b95dcb8d483ce4b8d97de85c6a352fb67a62cc38..c18a5b96de5ce78cd87d35878e82d293f0c201cc 100644 (file)
@@ -333,9 +333,9 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
                        else
                                status = valid ? "Invalid" : "Free";
                }
-               buf_len += sysfs_emit(buf + buf_len, "%d:%s ", key, status);
+               buf_len += sysfs_emit_at(buf, buf_len, "%d:%s ", key, status);
        }
-       buf_len += sysfs_emit(buf + buf_len, "\n");
+       buf_len += sysfs_emit_at(buf, buf_len, "\n");
 
        return buf_len;
 }