]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
auth: Remove duplicate "nodelay" extra field sent as passdb reply
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Mon, 2 Jan 2023 00:51:22 +0000 (02:51 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Fri, 27 Jan 2023 09:34:54 +0000 (09:34 +0000)
The auth clients just ignored the duplicate, so this didn't cause any
visible bugs.

The "nodelay" field was originally added as a hidden field, which wouldn't
be sent as a passdb reply. However, the "nodelay" field became visible
again in 4307e3a2320dabbac53ad712790ffd250d527108.

src/auth/auth-request-handler.c

index f6a77a833840eafcb1d65b62a675d9d91a1e7656..cb07270bbebe22f61146dd2fda6f96596909ef4f 100644 (file)
@@ -336,11 +336,6 @@ auth_request_handler_reply_failure_finish(struct auth_request *request)
                }
        }
 
-       if (auth_fields_exists(request->fields.extra_fields, "nodelay")) {
-               /* this is normally a hidden field, need to add it explicitly */
-               str_append(str, "\tnodelay");
-       }
-
        if (code != NULL) {
                str_append(str, "\tcode=");
                str_append(str, code);