Fix the memory leak in procMgr library.

In a specific code path, procCmdAbsPath attribute is ovewritten
with the new memory. This leads to a memory leak for the previously
allocated memory.

diff --git a/open-vm-tools/lib/procMgr/procMgrPosix.c b/open-vm-tools/lib/procMgr/procMgrPosix.c
index 8acde5c983b11933e2e32c7a850a77c871334164..980583303d8291a93847b4a8a8643ac927685022 100644 (file)
--- a/open-vm-tools/lib/procMgr/procMgrPosix.c
+++ b/open-vm-tools/lib/procMgr/procMgrPosix.c
@@ -428,7 +428,7 @@ ProcMgr_ListProcesses(void)
                      cmdNameBegin = cmdLineTemp;
                   }
                   procInfo.procCmdName = Unicode_Alloc(cmdNameBegin, STRING_ENCODING_DEFAULT);
-                  if (procInfo.procCmdAbsPath != NULL &&
+                  if (procInfo.procCmdAbsPath == NULL &&
                       cmdLineTemp[0] == '/') {
                      procInfo.procCmdAbsPath =
                         Unicode_Alloc(cmdLineTemp, STRING_ENCODING_DEFAULT);
@@ -498,7 +498,7 @@ ProcMgr_ListProcesses(void)
              * Store the command name.
              */
             procInfo.procCmdName = Unicode_Alloc(cmdLineTemp, STRING_ENCODING_DEFAULT);
-            if (procInfo.procCmdAbsPath != NULL &&
+            if (procInfo.procCmdAbsPath == NULL &&
                 cmdLineTemp[0] == '/') {
                procInfo.procCmdAbsPath = Unicode_Alloc(cmdLineTemp, STRING_ENCODING_DEFAULT);
             }