]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 602832: 008filter.t doesn't catch [%~ ~%] correctly
authorFrédéric Buclin <LpSolit@gmail.com>
Sat, 9 Oct 2010 11:19:43 +0000 (13:19 +0200)
committerFrédéric Buclin <LpSolit@gmail.com>
Sat, 9 Oct 2010 11:19:43 +0000 (13:19 +0200)
r/a=mkanat

t/008filter.t

index 5a5b223c8a22982f2845f51300ceb4f712df98a0..6f95943abf0dab83f91aac165141922e76df6666 100644 (file)
@@ -110,7 +110,7 @@ foreach my $path (@Support::Templates::include_paths) {
 
         # /g means we execute this loop for every match
         # /s means we ignore linefeeds in the regexp matches
-        while ($slurp =~ /\[%(.*?)%\]/gs) {
+        while ($slurp =~ /\[%(?:-|\+|~)?(.*?)(?:-|\+|~)?%\]/gs) {
             my $directive = $1;
 
             my @lineno = ($` =~ m/\n/gs);
@@ -155,11 +155,11 @@ sub directive_ok {
     my ($file, $directive) = @_;
 
     # Comments
-    return 1 if $directive =~ /^[+-]?#/;        
+    return 1 if $directive =~ /^#/;        
 
-    # Remove any leading/trailing + or - and whitespace.
-    $directive =~ s/^[+-]?\s*//;
-    $directive =~ s/\s*[+-]?$//;
+    # Remove any leading/trailing whitespace.
+    $directive =~ s/^\s*//;
+    $directive =~ s/\s*$//;
 
     # Empty directives are ok; they are usually line break helpers
     return 1 if $directive eq '';