libsmb: Fix CID 1438244 Unsigned compared against 0

ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only
case that ndr_size_dom_sid returns 0 is a NULL sid
pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the
number of sub-auths is a uint8. That times 4 plus 8 always fits into a
size_t.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
index 26079a02eca3b8842dd257aff7791e22b4c0e32e..561efe371a454a2d78f044b702c918f0e632c4f4 100644 (file)
--- a/source3/libsmb/cli_smb2_fnum.c
+++ b/source3/libsmb/cli_smb2_fnum.c
@@ -2948,10 +2948,6 @@ NTSTATUS cli_smb2_get_user_quota(struct cli_state *cli,
        sid_len = ndr_size_dom_sid(&pqt->sid, 0);
 
        query.return_single = 1;
-       if (sid_len < 0) {
-               status = NT_STATUS_INVALID_PARAMETER;
-               goto fail;
-       }
 
        info.next_entry_offset = 0;
        info.sid_length = sid_len;