Use INITERROR macro in utils.c

Remove py3k check where we initialize the module and
instead make this look like the same init sequence
as resultproxy.c, processors.c

Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com>
Change-Id: Ia6352e50eaf760d95ab2bbf66d90c023c37f1193
Pull-request: https://github.com/zzzeek/sqlalchemy/pull/429

diff --git a/lib/sqlalchemy/cextension/utils.c b/lib/sqlalchemy/cextension/utils.c
index d9cf93d0afcd93c0e0dc6951de54ccf34ac1d1a1..b13157aa7fc7fbd5102375a21e3175aa92534787 100644 (file)
--- a/lib/sqlalchemy/cextension/utils.c
+++ b/lib/sqlalchemy/cextension/utils.c
@@ -187,6 +187,8 @@ static PyMethodDef module_methods[] = {
 
 #if PY_MAJOR_VERSION >= 3
 
+#define INITERROR return NULL
+
 static struct PyModuleDef module_def = {
     PyModuleDef_HEAD_INIT,
     MODULE_NAME,
@@ -194,16 +196,19 @@ static struct PyModuleDef module_def = {
     -1,
     module_methods
  };
-#endif
 
-
-#if PY_MAJOR_VERSION >= 3
 PyMODINIT_FUNC
 PyInit_cutils(void)
+
 #else
+
+#define INITERROR return
+
 PyMODINIT_FUNC
 initcutils(void)
+
 #endif
+
 {
     PyObject *m;
 
@@ -212,14 +217,11 @@ initcutils(void)
 #else
     m = Py_InitModule3(MODULE_NAME, module_methods, MODULE_DOC);
 #endif
+    if (m == NULL)
+        INITERROR;
 
 #if PY_MAJOR_VERSION >= 3
-    if (m == NULL)
-        return NULL;
     return m;
-#else
-    if (m == NULL)
-       return;
 #endif
 }