]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect: fix memory leak in error handling
authorVictor Julien <vjulien@oisf.net>
Tue, 20 Feb 2024 15:06:57 +0000 (16:06 +0100)
committerVictor Julien <victor@inliniac.net>
Thu, 29 Feb 2024 10:24:41 +0000 (11:24 +0100)
Pointed out by cppcheck:

src/detect-parse.c:1544:9: error: Memory leak: sig.init_data [memleak]
        SCFree(sig);
        ^

Bug: #6527.
(cherry picked from commit eb1d0c2cc2b673a8f751cd88546e7c37e33ab8e0)

src/detect-parse.c

index b5e214df24458c4d0ef85732563d076c4d2a1769..c3232b97daac01ad9fd7afaef4a3e057eb1fc9ff 100644 (file)
@@ -1540,6 +1540,7 @@ Signature *SigAlloc (void)
 
     sig->init_data->buffers = SCCalloc(8, sizeof(SignatureInitDataBuffer));
     if (sig->init_data->buffers == NULL) {
+        SCFree(sig->init_data);
         SCFree(sig);
         return NULL;
     }