]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
ifstat: handle strdup return value
authorDenis Kirjanov <kirjanov@gmail.com>
Mon, 18 Mar 2024 09:15:41 +0000 (05:15 -0400)
committerStephen Hemminger <stephen@networkplumber.org>
Wed, 20 Mar 2024 04:17:55 +0000 (21:17 -0700)
get_nlmsg_extended is missing the check as
it's done in get_nlmsg

v2: don't set the errno value explicitly

Signed-off-by: Denis Kirjanov <dkirjanov@suse.de>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
misc/ifstat.c

index 685e66c9c1b208334ee0688fd1a6e0c73221b2fb..352e5622c03d0a92921355fd4297336bc244d1ee 100644 (file)
@@ -140,6 +140,10 @@ static int get_nlmsg_extended(struct nlmsghdr *m, void *arg)
 
        n->ifindex = ifsm->ifindex;
        n->name = strdup(ll_index_to_name(ifsm->ifindex));
+       if (!n->name) {
+               free(n);
+               return -1;
+       }
 
        if (sub_type == NO_SUB_TYPE) {
                memcpy(&n->val, RTA_DATA(tb[filter_type]), sizeof(n->val));