drm/amd/powerplay: fix memory leakage when reload (v2)

[ Upstream commit a25513e7b9b15c318ec44113682e988829aef746 ]

add smu_free_memory when smu fini to prevent memory leakage

v2: squash in typo fix (Yintian) and warning (Harry)

Signed-off-by: Yintian Tao <yttao@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
index 7f5359a97ef2d8f4a4182b1e708a2eff071f4be0..885d9d8026701b91739ba74c314cbcc6f34581f3 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
@@ -648,6 +648,12 @@ int smu7_init(struct pp_hwmgr *hwmgr)
 
 int smu7_smu_fini(struct pp_hwmgr *hwmgr)
 {
+       struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend);
+
+       smu_free_memory(hwmgr->device, (void *) smu_data->header_buffer.handle);
+       if (!cgs_is_virtualization_enabled(hwmgr->device))
+               smu_free_memory(hwmgr->device, (void *) smu_data->smu_buffer.handle);
+
        kfree(hwmgr->smu_backend);
        hwmgr->smu_backend = NULL;
        cgs_rel_firmware(hwmgr->device, CGS_UCODE_ID_SMU);