]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: tegra: xusb: Explicitly configure HS_DISCON_LEVEL to 0x7
authorWayne Chang <waynec@nvidia.com>
Fri, 12 Dec 2025 03:21:16 +0000 (11:21 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 24 Dec 2025 07:07:27 +0000 (12:37 +0530)
The USB2 Bias Pad Control register manages analog parameters for signal
detection. Previously, the HS_DISCON_LEVEL relied on hardware reset
values, which may lead to the detection failure.

Explicitly configure HS_DISCON_LEVEL to 0x7. This ensures the disconnect
threshold is sufficient to guarantee reliable detection.

Fixes: bbf711682cd5 ("phy: tegra: xusb: Add Tegra186 support")
Cc: stable@vger.kernel.org
Signed-off-by: Wayne Chang <waynec@nvidia.com>
Link: https://patch.msgid.link/20251212032116.768307-1-waynec@nvidia.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/tegra/xusb-tegra186.c

index e818f6c3980e6b9028567db09404b31e5a839b5d..bec9616c4a2e0de76b5edf56bd907b03d295b196 100644 (file)
@@ -84,6 +84,7 @@
 #define XUSB_PADCTL_USB2_BIAS_PAD_CTL0         0x284
 #define  BIAS_PAD_PD                           BIT(11)
 #define  HS_SQUELCH_LEVEL(x)                   (((x) & 0x7) << 0)
+#define  HS_DISCON_LEVEL(x)                    (((x) & 0x7) << 3)
 
 #define XUSB_PADCTL_USB2_BIAS_PAD_CTL1         0x288
 #define  USB2_TRK_START_TIMER(x)               (((x) & 0x7f) << 12)
@@ -623,6 +624,8 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
        value &= ~BIAS_PAD_PD;
        value &= ~HS_SQUELCH_LEVEL(~0);
        value |= HS_SQUELCH_LEVEL(priv->calib.hs_squelch);
+       value &= ~HS_DISCON_LEVEL(~0);
+       value |= HS_DISCON_LEVEL(0x7);
        padctl_writel(padctl, value, XUSB_PADCTL_USB2_BIAS_PAD_CTL0);
 
        udelay(1);