Bug 28398 Gotta be more careful when emailing state changes of dependent bugs

Patch by AndrÃ\83© Batosti <batosti@async.com.br>
r=lpsolit, a=justdave

diff --git a/process_bug.cgi b/process_bug.cgi
index e98005a9cbc97e3a9f65e744d2b23f240454bbb5..af3ebc977843074f3831a4a64f03db1846b362af 100755 (executable)
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -1914,9 +1914,9 @@ foreach my $id (@idlist) {
             $vars->{'id'} = $k;
             $vars->{'type'} = "dep";
 
-            # Let the user know we checked to see if we should email notice
-            # of this change to users with a relationship to the dependent
-            # bug and who did and didn't receive email about it.
+            # Let the user (if he is able to see the bug) know we checked to see 
+            # if we should email notice of this change to users with a relationship
+            # to the dependent bug and who did and didn't receive email about it.
             $template->process("bug/process/results.html.tmpl", $vars)
               || ThrowTemplateError($template->error());
             $vars->{'header_done'} = 1;

diff --git a/template/en/default/bug/process/bugmail.html.tmpl b/template/en/default/bug/process/bugmail.html.tmpl
index a2a6e7353eb5905888517e0193697a977ac1538a..a5d20e78dddeac3ca74c3426b698fba478be44c8 100644 (file)
--- a/template/en/default/bug/process/bugmail.html.tmpl
+++ b/template/en/default/bug/process/bugmail.html.tmpl
@@ -62,11 +62,15 @@
 
 [% BLOCK emails %]
   <b>[% description FILTER html %]:</b>
-  [% IF names.size > 0 %]
-    [%+ FOREACH name = names %]
-      [% name FILTER html %][% ", " UNLESS loop.last() %]
+  [% IF user.can_see_bug(mailing_bugid) %]
+    [% IF names.size > 0 %]
+      [%+ FOREACH name = names %]
+        [% name FILTER html %][% ", " UNLESS loop.last() %]
+      [% END %]
+    [% ELSE %]
+      no one
     [% END %]
   [% ELSE %]
-    no one
+    (list of e-mails not avaliable)
   [% END %]
 [% END %]