]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Missing unlock
authorMark Andrews <marka@isc.org>
Sun, 7 Dec 2025 22:59:29 +0000 (09:59 +1100)
committerMark Andrews <marka@isc.org>
Sun, 7 Dec 2025 22:59:29 +0000 (09:59 +1100)
'kasp->lock' was not released before returning.

lib/dns/zone.c

index 927c57e80939e121706ccd0e56626faced408206..1637af0e89f50dcc2a3f7a832d745dc72a37bf32 100644 (file)
@@ -22128,6 +22128,7 @@ isc_result_t
 dns_zone_dnssecstatus(dns_zone_t *zone, dns_kasp_t *kasp,
                      dns_dnsseckeylist_t *keys, isc_stdtime_t now,
                      bool verbose, char *out, size_t out_len) {
+       isc_result_t result;
        isc_buffer_t buf;
        isc_time_t refreshkeytime;
        isc_stdtime_t refresh;
@@ -22152,10 +22153,10 @@ dns_zone_dnssecstatus(dns_zone_t *zone, dns_kasp_t *kasp,
 
        bool checkds = zone->checkdstype != dns_checkdstype_no;
        LOCK(&kasp->lock);
-       RETERR(dns_keymgr_status(kasp, keys, &buf, now, verbose, checkds));
+       result = dns_keymgr_status(kasp, keys, &buf, now, verbose, checkds);
        UNLOCK(&kasp->lock);
 
-       return ISC_R_SUCCESS;
+       return result;
 }
 
 isc_result_t