]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested
authorPeter Krempa <pkrempa@redhat.com>
Thu, 26 Apr 2018 13:44:26 +0000 (15:44 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 30 Apr 2018 05:44:39 +0000 (07:44 +0200)
Since libvirt is currently not able to setup the NBD migration stream
secured by TLS we should not allow such migration since data would be
transferred unencrypted.

This will break compatibility of TLS migration if non-shared storage is
requested but the security implications are more severe.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_migration.c

index 88b8253fa996d55b9fea28416d519b6e2a030307..b913e999289320191db3649b690218e2986935fc 100644 (file)
@@ -3339,6 +3339,16 @@ qemuMigrationSrcRun(virQEMUDriverPtr driver,
     if (migrate_flags & (QEMU_MONITOR_MIGRATE_NON_SHARED_DISK |
                          QEMU_MONITOR_MIGRATE_NON_SHARED_INC)) {
         if (mig->nbd) {
+            /* Currently libvirt does not support setting up of the NBD
+             * non-shared storage migration with TLS. As we need to honour the
+             * VIR_MIGRATE_TLS flag, we need to reject such migration until
+             * we implement TLS for NBD. */
+            if (flags & VIR_MIGRATE_TLS) {
+                virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                               _("NBD migration with TLS is not supported"));
+                goto error;
+            }
+
             /* This will update migrate_flags on success */
             if (qemuMigrationSrcDriveMirror(driver, vm, mig,
                                             spec->dest.host.name,