]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: use insertAt instead of j
authorJán Tomko <jtomko@redhat.com>
Mon, 11 Apr 2016 12:45:46 +0000 (14:45 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 12 Apr 2016 08:45:35 +0000 (10:45 +0200)
We call VIR_INSERT_ELEMENT_INPLACE either with 0 (for primary video)
or def->nvideos (for the rest).

Use a variable with more semantic name, since j is usually used
for iterating.

src/conf/domain_conf.c

index 690287d879ce8fea65486bfc4965947d6ede21d2..d6d4334247ad3d8c870a3a14f43386b5c939371d 100644 (file)
@@ -16420,8 +16420,8 @@ virDomainDefParseXML(xmlDocPtr xml,
     if (n && VIR_ALLOC_N(def->videos, n) < 0)
         goto error;
     for (i = 0; i < n; i++) {
-        j = def->nvideos;
         virDomainVideoDefPtr video;
+        ssize_t insertAt = -1;
 
         if (!(video = virDomainVideoDefParseXML(nodes[i], def, flags)))
             goto error;
@@ -16434,11 +16434,11 @@ virDomainDefParseXML(xmlDocPtr xml,
                 goto error;
             }
 
-            j = 0;
+            insertAt = 0;
             primaryVideo = true;
         }
         if (VIR_INSERT_ELEMENT_INPLACE(def->videos,
-                                       j,
+                                       insertAt,
                                        def->nvideos,
                                        video) < 0) {
             virDomainVideoDefFree(video);