]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
output/alert: Correct FORWARD_NULL Coverity issue.
authorJeff Lucovsky <jeff@lucovsky.org>
Fri, 10 Jul 2020 12:23:56 +0000 (08:23 -0400)
committerJeff Lucovsky <jeff@lucovsky.org>
Fri, 10 Jul 2020 12:23:56 +0000 (08:23 -0400)
This commit corrects the FORWARD_NULL issue in AlertJson by
null-checking p->flow

src/output-json-alert.c

index c796aceee1d466465a77bd214b5a5b4f1b79ac69..113070e6acde2f8c95ebe61a1f296fa6bd395868 100644 (file)
@@ -563,7 +563,7 @@ static int AlertJson(ThreadVars *tv, JsonAlertLogThread *aft, const Packet *p)
         }
 
         /* including fileinfo data is configured by the metadata setting */
-        if (json_output_ctx->flags & LOG_JSON_RULE_METADATA) {
+        if (json_output_ctx->flags & LOG_JSON_RULE_METADATA && p->flow != NULL) {
             FileContainer *ffc = AppLayerParserGetFiles(p->flow,
                     p->flowflags & FLOW_PKT_TOSERVER ? STREAM_TOSERVER:STREAM_TOCLIENT);
             if (ffc != NULL) {