]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
linux-user/elfload: Don't close an unopened file descriptor
authorRichard Henderson <richard.henderson@linaro.org>
Tue, 5 Mar 2024 20:15:50 +0000 (10:15 -1000)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 12 Mar 2024 13:36:19 +0000 (03:36 -1000)
Fixes Coverity CID: 1534964
Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
linux-user/elfload.c

index 4dbca056461b93e287931e4f6005755a22a16599..26d4c1d6b37879fc44ce3a704e8820731cc1ab81 100644 (file)
@@ -4522,7 +4522,9 @@ static int elf_core_dump(int signr, const CPUArchState *env)
     ret = -errno;
     mmap_unlock();
     cpu_list_unlock();
-    close(fd);
+    if (fd >= 0) {
+        close(fd);
+    }
     return ret;
 }
 #endif /* USE_ELF_CORE_DUMP */