]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
ftests: add test to replace scope idle_thread using cgclassify
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Thu, 15 Jun 2023 11:22:06 +0000 (16:52 +0530)
committerTom Hromatka <tom.hromatka@oracle.com>
Wed, 21 Jun 2023 16:11:19 +0000 (10:11 -0600)
Add a test to replace systemd scope default idle_thread using
cgclassify '-r' flag.
-----------------------------------------------------------------
Test Results:
        Run Date:                          Jun 15 11:20:25
        Passed:                                  1 test(s)
        Skipped:                                 0 test(s)
        Failed:                                  0 test(s)
-----------------------------------------------------------------
Timing Results:
        Test                                     Time (sec)
        ---------------------------------------------------
        setup                                          0.00
        088-sudo-cgclassify_systemd_scope.py          17.63
        teardown                                       0.00
        ---------------------------------------------------
        Total Run Time                                17.63

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
tests/ftests/088-sudo-cgclassify_systemd_scope.py [new file with mode: 0755]
tests/ftests/Makefile.am

diff --git a/tests/ftests/088-sudo-cgclassify_systemd_scope.py b/tests/ftests/088-sudo-cgclassify_systemd_scope.py
new file mode 100755 (executable)
index 0000000..6be897b
--- /dev/null
@@ -0,0 +1,185 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: LGPL-2.1-only
+#
+# Test to replace idle_thread of scope unit using cgclassify -r
+#
+# Copyright (c) 2023 Oracle and/or its affiliates.
+# Author: Kamalesh Babulal <kamalesh.babulal@oracle.com>
+#
+
+from process import Process
+from cgroup import Cgroup
+from run import RunError
+import consts
+import ftests
+import time
+import sys
+import os
+
+CONTROLLER = 'cpu'
+SLICE = 'libcgroup.slice'
+CGNAME = os.path.join(SLICE, '088cgcreate.scope')
+OUT_OF_SCOPE_CGNAME1 = '088outofscope'
+OUT_OF_SCOPE_CGNAME2 = '088outofscope.scope'
+
+
+def prereqs(config):
+    result = consts.TEST_PASSED
+    cause = None
+
+    if config.args.container:
+        result = consts.TEST_SKIPPED
+        cause = 'This test cannot be run within a container'
+
+    return result, cause
+
+
+def setup(config):
+    pass
+
+
+def test(config):
+    result = consts.TEST_PASSED
+    cause = None
+
+    #
+    # Test 1: call cgclassify -r to replace idle_thread with infinite while loop
+    #
+    Cgroup.create_and_validate(config, CONTROLLER, CGNAME, create_scope=True)
+    idle_pid = Cgroup.get_pids_in_cgroup(config, CGNAME, CONTROLLER)[0]
+
+    config.process.create_process_in_cgroup(config, CONTROLLER, CGNAME,
+                                            cgclassify=True, replace_idle=True)
+
+    # We need pause, before the cgroups.procs gets updated, post cgclassify
+    time.sleep(1)
+
+    pid = Cgroup.get_pids_in_cgroup(config, CGNAME, CONTROLLER)
+    if len(pid) > 1 and idle_pid == pid[0]:
+        result = consts.TEST_FAILED
+        cause = 'Failed to replace scope idle_thread pid {}'.format(idle_pid)
+        return result, cause
+
+    #
+    # Test 2: call cgclassify -r to replace non-idle_thread (while loop,
+    #         previously created) with another while loop.
+    #
+    try:
+        config.process.create_process_in_cgroup(config, CONTROLLER, CGNAME,
+                                                cgclassify=True, replace_idle=True)
+    except RunError as re:
+        if "Failed to find idle_thread task" not in re.stderr:
+            raise re
+    else:
+        result = consts.TEST_FAILED
+        cause = 'Erroneously classified a task in scope cgroup {}\n'.format(CGNAME)
+        return result, cause
+
+    # We need pause, before the cgroups.procs gets updated, post cgclassify
+    time.sleep(1)
+
+    replace_pid = Cgroup.get_pids_in_cgroup(config, CGNAME, CONTROLLER)
+    if replace_pid[0] != pid[0]:
+        result = consts.TEST_FAILED
+        cause = ('Erroneously replaced scope non idle_thread pid {} with '
+                 'pid {}'.format(pid[0], replace_pid[0]))
+        return result, cause
+
+    #
+    # Test 3: create a non-scope cgroup, try creating a task with replace_idle
+    #         set.
+    #
+    Cgroup.create_and_validate(config, CONTROLLER, OUT_OF_SCOPE_CGNAME1)
+    try:
+        config.process.create_process_in_cgroup(config, CONTROLLER, OUT_OF_SCOPE_CGNAME1,
+                                                cgclassify=True, replace_idle=True)
+    except RunError as re:
+        if "Failed to find idle_thread task" not in re.stderr:
+            raise re
+    else:
+        result = consts.TEST_FAILED
+        cause = ('Erroneously classified a task in non scope '
+                 'cgroup {}\n'.format(OUT_OF_SCOPE_CGNAME1))
+        return result, cause
+
+    # We need pause, before the cgroups.procs gets updated, post cgclassify
+    time.sleep(1)
+
+    pid = Cgroup.get_pids_in_cgroup(config, OUT_OF_SCOPE_CGNAME1, CONTROLLER)
+    if len(pid) != 0:
+        result = consts.TEST_FAILED
+        cause = ('Erroneously classified a task in non scope '
+                 'cgroup {}\n'.format(OUT_OF_SCOPE_CGNAME1))
+        return result, cause
+
+    #
+    # Test 4: create a non-scope cgroup with .scope suffix, try creating a task with
+    #         replace_idle set.
+    #
+    Cgroup.create_and_validate(config, CONTROLLER, OUT_OF_SCOPE_CGNAME2)
+    try:
+        config.process.create_process_in_cgroup(config, CONTROLLER, OUT_OF_SCOPE_CGNAME2,
+                                                cgclassify=True, replace_idle=True)
+    except RunError as re:
+        if "Failed to find idle_thread task" not in re.stderr:
+            raise re
+    else:
+        result = consts.TEST_FAILED
+        cause = ('Erroneously classified a task in non scope '
+                 'cgroup {}\n'.format(OUT_OF_SCOPE_CGNAME2))
+        return result, cause
+
+    # We need pause, before the cgroups.procs gets updated, post cgclassify
+    time.sleep(1)
+
+    pid = Cgroup.get_pids_in_cgroup(config, OUT_OF_SCOPE_CGNAME2, CONTROLLER)
+    if len(pid) != 0:
+        result = consts.TEST_FAILED
+        cause = ('Erroneously classified a task in non scope '
+                 'cgroup {}\n'.format(OUT_OF_SCOPE_CGNAME2))
+
+    return result, cause
+
+
+def teardown(config):
+    pid = Cgroup.get_pids_in_cgroup(config, OUT_OF_SCOPE_CGNAME1, CONTROLLER)
+    Process.kill(config, pid)
+
+    pid = Cgroup.get_pids_in_cgroup(config, OUT_OF_SCOPE_CGNAME2, CONTROLLER)
+    Process.kill(config, pid)
+
+    Cgroup.delete(config, CONTROLLER, OUT_OF_SCOPE_CGNAME1)
+    Cgroup.delete(config, CONTROLLER, OUT_OF_SCOPE_CGNAME2)
+
+    pid = Cgroup.get_pids_in_cgroup(config, CGNAME, CONTROLLER)
+    Process.kill(config, pid)
+
+    # systemd will automatically remove the cgroup once there are no more pids in
+    # the cgroup, so we don't need to delete CGNAME.  But let's try to remove the
+    # slice
+    try:
+        Cgroup.delete(config, CONTROLLER, SLICE)
+    except RunError:
+        pass
+
+
+def main(config):
+    [result, cause] = prereqs(config)
+    if result != consts.TEST_PASSED:
+        return [result, cause]
+
+    setup(config)
+
+    [result, cause] = test(config)
+    teardown(config)
+
+    return [result, cause]
+
+
+if __name__ == '__main__':
+    config = ftests.parse_args()
+    # this test was invoked directly.  run only it
+    config.args.num = int(os.path.basename(__file__).split('-')[0])
+    sys.exit(ftests.main(config))
+
+# vim: set et ts=4 sw=4:
index 889d8d39bf9615e0329fe26ff3afad7b85e8a229..e38d641bbf9c84b9a5459d5043df2054bb046092 100644 (file)
@@ -108,6 +108,7 @@ EXTRA_DIST_PYTHON_TESTS = \
                          085-sudo-cgexec_systemd_scope.py \
                          086-sudo-systemd_cmdline_example.py \
                          087-sudo-move_pid.py \
+                         088-sudo-cgclassify_systemd_scope.py \
                          998-cgdelete-non-existing-shared-mnt-cgroup-v1.py
 # Intentionally omit the stress test from the extra dist
 # 999-stress-cgroup_init.py