]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
disassociate rdatasets when cleaning up
authorMark Andrews <marka@isc.org>
Tue, 21 Dec 2021 01:44:17 +0000 (12:44 +1100)
committerMark Andrews <marka@isc.org>
Wed, 13 Jul 2022 23:43:39 +0000 (23:43 +0000)
free_namelist could be passed names with associated rdatasets
when handling errors.  These need to be disassociated before
calling dns_message_puttemprdataset.

lib/dns/tkey.c

index edb60eafec5c7fab0e35939d9dac704213106009..69484be5645db7cc63ddc9f77a34f1abd7ca7bfc 100644 (file)
@@ -227,6 +227,9 @@ free_namelist(dns_message_t *msg, dns_namelist_t *namelist) {
                while (!ISC_LIST_EMPTY(name->list)) {
                        set = ISC_LIST_HEAD(name->list);
                        ISC_LIST_UNLINK(name->list, set, link);
+                       if (dns_rdataset_isassociated(set)) {
+                               dns_rdataset_disassociate(set);
+                       }
                        dns_message_puttemprdataset(msg, &set);
                }
                dns_message_puttempname(msg, &name);