]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
lxc/conf: do not leak opts.data memory in __lxc_idmapped_mounts_child() 4567/head
authorAlexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Tue, 29 Jul 2025 10:41:11 +0000 (12:41 +0200)
committerAlexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Tue, 29 Jul 2025 10:41:11 +0000 (12:41 +0200)
Fixes: Coverity 1641425
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
src/lxc/conf.c

index 6c0e3d3c9515a399dd5a0e2d9bd89b5a0e98d6e1..1899b2806d70a367d0df7ac558bab1c823f51f0b 100644 (file)
@@ -2682,11 +2682,11 @@ static int __lxc_idmapped_mounts_child(struct lxc_handler *handler, FILE *f)
                ret = parse_lxc_mount_attrs(&opts, mntent.mnt_opts);
                if (ret < 0)
                        return syserror("Failed to parse LXC specific mount options");
-               __data = opts.data;
 
                ret = parse_mount_attrs(&opts, mntent.mnt_opts);
                if (ret < 0)
                        return syserror("Failed to parse mount options");
+               __data = opts.data;
 
                /* No idmapped mount entry so skip it. */
                if (is_empty_string(opts.userns_path))