]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: mpt3sas: Simplify an alloc_ordered_workqueue() invocation
authorBart Van Assche <bvanassche@acm.org>
Thu, 22 Aug 2024 19:59:13 +0000 (12:59 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 23 Aug 2024 01:28:56 +0000 (21:28 -0400)
Let alloc_ordered_workqueue() format the workqueue name instead of calling
snprintf() explicitly.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240822195944.654691-10-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.h
drivers/scsi/mpt3sas/mpt3sas_scsih.c

index fe1e96fda284bc54430c15052fa98eebe3f5436e..eceb5eeb4651321f7cbdb5884faadd0db4fbc775 100644 (file)
@@ -1162,8 +1162,7 @@ typedef void (*MPT3SAS_FLUSH_RUNNING_CMDS)(struct MPT3SAS_ADAPTER *ioc);
  * @fault_reset_work_q_name: fw fault work queue
  * @fault_reset_work_q: ""
  * @fault_reset_work: ""
- * @firmware_event_name: fw event work queue
- * @firmware_event_thread: ""
+ * @firmware_event_thread: fw event work queue
  * @fw_event_lock:
  * @fw_event_list: list of fw events
  * @current_evet: current processing firmware event
@@ -1351,7 +1350,6 @@ struct MPT3SAS_ADAPTER {
        struct delayed_work fault_reset_work;
 
        /* fw event handler */
-       char            firmware_event_name[20];
        struct workqueue_struct *firmware_event_thread;
        spinlock_t      fw_event_lock;
        struct list_head fw_event_list;
index 97c2472cd4343e1a4b7fa408b12f3405c72bff8e..728cced42b0e3c5bda7d9d04ac675eb0276c5274 100644 (file)
@@ -12301,10 +12301,8 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        scsi_host_set_guard(shost, SHOST_DIX_GUARD_CRC);
 
        /* event thread */
-       snprintf(ioc->firmware_event_name, sizeof(ioc->firmware_event_name),
-           "fw_event_%s%d", ioc->driver_name, ioc->id);
        ioc->firmware_event_thread = alloc_ordered_workqueue(
-           ioc->firmware_event_name, 0);
+               "fw_event_%s%d", 0, ioc->driver_name, ioc->id);
        if (!ioc->firmware_event_thread) {
                ioc_err(ioc, "failure at %s:%d/%s()!\n",
                        __FILE__, __LINE__, __func__);