]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Block blockjobs when transient disk option is enabled
authorMasayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Thu, 17 Sep 2020 13:30:40 +0000 (09:30 -0400)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 1 Oct 2020 07:55:02 +0000 (09:55 +0200)
For now we disallow blockjobs with transient disks to avoid dealing with
obsoleted overlays.

Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Tested-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_domain.c

index dc5949edfa6f582d12f987d15586a403f6db3bb0..0331fd55e021eece62b42a905f025b7690903322 100644 (file)
@@ -10859,6 +10859,13 @@ qemuDomainDiskBlockJobIsSupported(virDomainObjPtr vm,
         return false;
     }
 
+    if (disk->transient) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                       _("block jobs are not supported on transient disk '%s'"),
+                       disk->dst);
+        return false;
+    }
+
     return true;
 }