]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
fbdev: omapfb: remove duplicate check in omapfb_setup_mem()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 8 Jan 2026 20:00:57 +0000 (23:00 +0300)
committerHelge Deller <deller@gmx.de>
Sat, 14 Feb 2026 10:09:46 +0000 (11:09 +0100)
We know "size" is non-zero because it is checked on the line before.
Delete the duplicate check and pull the code in a tab.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/omap/omapfb_main.c

index 106d21e747381d7e202d21cf5b796f9adba41a41..a8740213e8916978658b696cc41e18e7c5358ced 100644 (file)
@@ -846,12 +846,10 @@ static int omapfb_setup_mem(struct fb_info *fbi, struct omapfb_mem_info *mi)
                 * be reenabled unless its size is > 0.
                 */
                if (old_size != size && size) {
-                       if (size) {
-                               memcpy(new_var, &fbi->var, sizeof(*new_var));
-                               r = set_fb_var(fbi, new_var);
-                               if (r < 0)
-                                       goto out;
-                       }
+                       memcpy(new_var, &fbi->var, sizeof(*new_var));
+                       r = set_fb_var(fbi, new_var);
+                       if (r < 0)
+                               goto out;
                }
 
                if (fbdev->ctrl->sync)