iio: dac: mcp47feb02: Fix mutex used before initialization

The mcp47feb02_parse_fw() function uses data->lock, but the mutex was
initialized after this function in probe path.

Since mcp47feb02_parse_fw() is only called from probe(), remove the lock.

Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c
index b218f0c3a0bd79f43dc9f2da1027f49a04e1975b..08fb85359697695c310de481d087871b5e8e0510 100644 (file)
--- a/drivers/iio/dac/mcp47feb02.c
+++ b/drivers/iio/dac/mcp47feb02.c
@@ -955,8 +955,6 @@ static int mcp47feb02_parse_fw(struct iio_dev *indio_dev,
        u32 num_channels;
        u8 chan_idx = 0;
 
-       guard(mutex)(&data->lock);
-
        num_channels = device_get_child_node_count(dev);
        if (num_channels > chip_features->phys_channels)
                return dev_err_probe(dev, -EINVAL, "More channels than the chip supports\n");