]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/irdma: Clean up unnecessary dereference of event->cm_node
authorIvan Barrera <ivan.d.barrera@intel.com>
Mon, 16 Mar 2026 18:39:43 +0000 (13:39 -0500)
committerLeon Romanovsky <leonro@nvidia.com>
Wed, 18 Mar 2026 10:20:53 +0000 (06:20 -0400)
The cm_node is available and the usage of cm_node and event->cm_node
seems arbitrary. Clean up unnecessary dereference of event->cm_node.

Fixes: 146b9756f14c ("RDMA/irdma: Add connection manager")
Signed-off-by: Ivan Barrera <ivan.d.barrera@intel.com>
Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/irdma/cm.c

index 3d084d4ff5770ecb016a7731c0a5b717672da093..13b24ffca265e0a63bcdc3374e9e98c6e04c5ab7 100644 (file)
@@ -4239,21 +4239,21 @@ static void irdma_cm_event_handler(struct work_struct *work)
                irdma_cm_event_reset(event);
                break;
        case IRDMA_CM_EVENT_CONNECTED:
-               if (!event->cm_node->cm_id ||
-                   event->cm_node->state != IRDMA_CM_STATE_OFFLOADED)
+               if (!cm_node->cm_id ||
+                   cm_node->state != IRDMA_CM_STATE_OFFLOADED)
                        break;
                irdma_cm_event_connected(event);
                break;
        case IRDMA_CM_EVENT_MPA_REJECT:
-               if (!event->cm_node->cm_id ||
+               if (!cm_node->cm_id ||
                    cm_node->state == IRDMA_CM_STATE_OFFLOADED)
                        break;
                irdma_send_cm_event(cm_node, cm_node->cm_id,
                                    IW_CM_EVENT_CONNECT_REPLY, -ECONNREFUSED);
                break;
        case IRDMA_CM_EVENT_ABORTED:
-               if (!event->cm_node->cm_id ||
-                   event->cm_node->state == IRDMA_CM_STATE_OFFLOADED)
+               if (!cm_node->cm_id ||
+                   cm_node->state == IRDMA_CM_STATE_OFFLOADED)
                        break;
                irdma_event_connect_error(event);
                break;
@@ -4263,7 +4263,7 @@ static void irdma_cm_event_handler(struct work_struct *work)
                break;
        }
 
-       irdma_rem_ref_cm_node(event->cm_node);
+       irdma_rem_ref_cm_node(cm_node);
        kfree(event);
 }