* src/storage_conf.c: add one missing check in virStoragePoolDefParseDoc

Daniel

diff --git a/ChangeLog b/ChangeLog
index b47840623d503f43c922e882327a1692fac79e1d..8ab308280e8543f53f978cc8c379b85dac317b4f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+Wed Sep  3 09:08:01 CEST 2008 Daniel Veillard <veillard@redhat.com>
+
+       * src/storage_conf.c: add one missing check in virStoragePoolDefParseDoc
+
 Tue Sep  2 17:30:50 CEST 2008 Daniel Veillard <veillard@redhat.com>
 
        * src/domain_conf.c: fix a parsing error for input devices

diff --git a/src/storage_conf.c b/src/storage_conf.c
index 2f6093beb661314ccf71f576188a03db645edb0f..dcc1fc2611086f908a6428dd8944b4e61713e669 100644 (file)
--- a/src/storage_conf.c
+++ b/src/storage_conf.c
@@ -331,6 +331,11 @@ virStoragePoolDefParseDoc(virConnectPtr conn,
         if (ret->source.name == NULL) {
             /* source name defaults to pool name */
             ret->source.name = strdup(ret->name);
+            if (ret->source.name == NULL) {
+                virStorageReportError(conn, VIR_ERR_NO_MEMORY, "%s",
+                                      _("pool name"));
+                goto cleanup;
+            }
         }
     }