]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
added semicolon (;) to improve warning message clarity
authorjonathan vanasco <jonathan@2xlp.com>
Tue, 30 Jun 2020 16:31:58 +0000 (12:31 -0400)
committersqla-tester <sqla-tester@sqlalchemy.org>
Tue, 30 Jun 2020 16:31:58 +0000 (12:31 -0400)
### Description

Added a semicolon to improve the clarity of warning message.  I actually had a table named `backend`, and thought it was involved!

While updating the code, I noticed no test that directly tests for this warning message. There are tests for the `Can't sort tables for DROP;` prefix of this message and the `exc.CircularDependencyError`; and some tests for the `exc.CircularDependencyError` message itself. I couldn't find any test for this particular message though.  (Just thought I'd bring that up)

No issue created, because this is minor.

Closes: #5431
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5431
Pull-request-sha: 87fb5733ff4fc1a13dd94277716814ea852f654c

Change-Id: I87a504d30a7dd5155c34f7d7f30b2116d0d3cd3f

lib/sqlalchemy/sql/ddl.py

index 17e3be2dac7534ba1ed8b5cd15e1fe4738661f63..3c23b50ca8a464d89ec35ece79bd672e9365fd15 100644 (file)
@@ -804,7 +804,7 @@ class SchemaDropper(DDLBase):
                 util.warn(
                     "Can't sort tables for DROP; an "
                     "unresolvable foreign key "
-                    "dependency exists between tables: %s, and backend does "
+                    "dependency exists between tables: %s; and backend does "
                     "not support ALTER.  To restore at least a partial sort, "
                     "apply use_alter=True to ForeignKey and "
                     "ForeignKeyConstraint "