]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wireless: purelifi: plfxlc: fix memory leak in plfxlc_usb_wreq_asyn()
authorSalah Triki <salah.triki@gmail.com>
Sun, 27 Apr 2025 09:57:45 +0000 (10:57 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:34 +0000 (11:07 +0100)
[ Upstream commit 63a9a727d373fa5b8ce509eef50dbc45e0f745b9 ]

Add usb_free_urb() in the error path to prevent memory leak.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
Link: https://patch.msgid.link/aA3_maPlEJzO7wrL@pc
[fix subject]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/purelifi/plfxlc/usb.c

index 311676c1ece0acbdfccf9ada7e926ae8f4b96897..8151bc5e00ccc8245fcf9b6475685f752349de8b 100644 (file)
@@ -503,8 +503,10 @@ int plfxlc_usb_wreq_async(struct plfxlc_usb *usb, const u8 *buffer,
                          (void *)buffer, buffer_len, complete_fn, context);
 
        r = usb_submit_urb(urb, GFP_ATOMIC);
-       if (r)
+       if (r) {
+               usb_free_urb(urb);
                dev_err(&udev->dev, "Async write submit failed (%d)\n", r);
+       }
 
        return r;
 }