]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dmaengine: sh: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Dec 2025 20:33:25 +0000 (21:33 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Dec 2025 06:49:32 +0000 (12:19 +0530)
Clobbering an error value to be returned from shdma_tx_submit() with
a pm_runtime_put() return value is not particularly useful, especially
if the latter is 0, so stop doing that.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/9626129.rMLUfLXkoz@rafael.j.wysocki
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/shdma-base.c

index 834741adadaade097260e48906fe429bc6cb01b2..1e4b4d6069c0e817d273a12446349f3eccaf5b7a 100644 (file)
@@ -143,7 +143,7 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx)
                                }
 
                                schan->pm_state = SHDMA_PM_ESTABLISHED;
-                               ret = pm_runtime_put(schan->dev);
+                               pm_runtime_put(schan->dev);
 
                                spin_unlock_irq(&schan->chan_lock);
                                return ret;