]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3: dwc3-octeon: Use FIELD_MODIFY()
authorHans Zhang <18255117159@163.com>
Thu, 30 Apr 2026 16:39:16 +0000 (00:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 May 2026 14:43:04 +0000 (16:43 +0200)
Use FIELD_MODIFY() to remove open-coded bit manipulation.
No functional change intended.

Signed-off-by: Hans Zhang <18255117159@163.com>
Link: https://patch.msgid.link/20260430163919.47372-4-18255117159@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-octeon.c

index 42bfc14ae0c4644595774e222b8948cb2e0b6da1..2201f0f34abb77df60acf4faa8772eaf4c1e0ca8 100644 (file)
@@ -296,8 +296,7 @@ static int dwc3_octeon_setup(struct dwc3_octeon *octeon,
                return div;
        }
        val = dwc3_octeon_readq(uctl_ctl_reg);
-       val &= ~USBDRD_UCTL_CTL_H_CLKDIV_SEL;
-       val |= FIELD_PREP(USBDRD_UCTL_CTL_H_CLKDIV_SEL, div);
+       FIELD_MODIFY(USBDRD_UCTL_CTL_H_CLKDIV_SEL, &val, div);
        val |= USBDRD_UCTL_CTL_H_CLK_EN;
        dwc3_octeon_writeq(uctl_ctl_reg, val);
        val = dwc3_octeon_readq(uctl_ctl_reg);
@@ -314,14 +313,11 @@ static int dwc3_octeon_setup(struct dwc3_octeon *octeon,
        /* Step 5a: Reference clock configuration. */
        val = dwc3_octeon_readq(uctl_ctl_reg);
        val &= ~USBDRD_UCTL_CTL_REF_CLK_DIV2;
-       val &= ~USBDRD_UCTL_CTL_REF_CLK_SEL;
-       val |= FIELD_PREP(USBDRD_UCTL_CTL_REF_CLK_SEL, ref_clk_sel);
+       FIELD_MODIFY(USBDRD_UCTL_CTL_REF_CLK_SEL, &val, ref_clk_sel);
 
-       val &= ~USBDRD_UCTL_CTL_REF_CLK_FSEL;
-       val |= FIELD_PREP(USBDRD_UCTL_CTL_REF_CLK_FSEL, ref_clk_fsel);
+       FIELD_MODIFY(USBDRD_UCTL_CTL_REF_CLK_FSEL, &val, ref_clk_fsel);
 
-       val &= ~USBDRD_UCTL_CTL_MPLL_MULTIPLIER;
-       val |= FIELD_PREP(USBDRD_UCTL_CTL_MPLL_MULTIPLIER, mpll_mul);
+       FIELD_MODIFY(USBDRD_UCTL_CTL_MPLL_MULTIPLIER, &val, mpll_mul);
 
        /* Step 5b: Configure and enable spread-spectrum for SuperSpeed. */
        val |= USBDRD_UCTL_CTL_SSC_EN;