]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI
authorPeter Krempa <pkrempa@redhat.com>
Tue, 19 Jul 2022 12:07:03 +0000 (14:07 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 11 Aug 2022 12:38:31 +0000 (14:38 +0200)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
30 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
src/qemu/qemu_process.c
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml
tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml
tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml
tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml
tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml
tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml
tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml
tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml
tests/qemucapabilitiesdata/caps_6.2.0.ppc64.xml
tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml
tests/qemucapabilitiesdata/caps_7.0.0.aarch64.xml
tests/qemucapabilitiesdata/caps_7.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml
tests/testutilsqemu.c

index 284d6ef6a966e3ecfa229969eb0e982f3ca8c0b4..f0f0f9f00d05fe2f4b5328a6da3f6d95009583d3 100644 (file)
@@ -595,7 +595,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
               "intel-iommu.aw-bits", /* QEMU_CAPS_INTEL_IOMMU_AW_BITS */
               "spapr-tpm-proxy", /* QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY */
               "numa.hmat", /* QEMU_CAPS_NUMA_HMAT */
-              "blockdev-hostdev-scsi", /* QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI */
+              "blockdev-hostdev-scsi", /* X_QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI */
 
               /* 380 */
               "usb-host.hostdevice", /* QEMU_CAPS_USB_HOST_HOSTDEVICE */
@@ -5227,7 +5227,6 @@ virQEMUCapsInitQMPVersionCaps(virQEMUCaps *qemuCaps)
     /* While the removal of pre-blockdev code is in progress we always hard-code
      * the support for QEMU_CAPS_BLOCKDEV */
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_BLOCKDEV);
-    virQEMUCapsSet(qemuCaps, QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI);
 
     /* -enable-fips is deprecated in QEMU 5.2.0, and QEMU
      * should be built with gcrypt to achieve FIPS compliance
index a9519ae74607791bc3e0d6e63ed3fda3e5925b15..dd03bbe25d872ec08cfd8642c7c0c64d6ba706a3 100644 (file)
@@ -574,7 +574,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     QEMU_CAPS_INTEL_IOMMU_AW_BITS, /* intel-iommu.aw-bits */
     QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY, /* -device spapr-tpm-proxy */
     QEMU_CAPS_NUMA_HMAT, /* -numa hmat */
-    QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI, /* -blockdev used for (i)SCSI hostdevs */
+    X_QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI, /* -blockdev used for (i)SCSI hostdevs */
 
     /* 380 */
     QEMU_CAPS_USB_HOST_HOSTDEVICE, /* -device usb-host.hostdevice */
index 9456d9c376bd87379a42382e82bd1bbd88f068af..2bdea2d14036f0362a023e48ab41b6736301693c 100644 (file)
@@ -5625,8 +5625,7 @@ qemuProcessStartUpdateCustomCaps(virDomainObj *vm)
 
             /* The code is being cleaned up to always assume the support for
              * -blockdev thus we must no longer allow users to clear it */
-            if (tmp == QEMU_CAPS_BLOCKDEV ||
-                tmp == QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI)
+            if (tmp == QEMU_CAPS_BLOCKDEV)
                 continue;
 
             virQEMUCapsClear(priv->qemuCaps, tmp);
@@ -5655,8 +5654,7 @@ qemuProcessStartUpdateCustomCaps(virDomainObj *vm)
 
             /* The code is being cleaned up to always assume the support for
              * -blockdev thus we must no longer allow users to clear it */
-            if (tmp == QEMU_CAPS_BLOCKDEV ||
-                tmp == QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI)
+            if (tmp == QEMU_CAPS_BLOCKDEV)
                 continue;
 
             virQEMUCapsClear(priv->qemuCaps, tmp);
index 5a00b9747c0d3dcd492991e438d87d0f7a4f175c..f74719af6159af27cf453e24e499adea6401948a 100644 (file)
   <flag name='virtio.packed'/>
   <flag name='tcg'/>
   <flag name='pvscsi'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='vhost-user-blk'/>
index 5aefa0fb4f5e66915f34ce06fc5e29fc5b2316ac..6c53e53b9d0531dcc8136c80ff0e3840919fe5d2 100644 (file)
   <flag name='tcg'/>
   <flag name='pvscsi'/>
   <flag name='spapr-tpm-proxy'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='vhost-user-blk'/>
index d15c36adeb2228884f3f391eb556e5789723c037..c05089585ad204ef1c7cea10b1590b17cdd2d55c 100644 (file)
   <flag name='fsdev.multidevs'/>
   <flag name='virtio.packed'/>
   <flag name='tcg'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='vhost-user-blk'/>
   <flag name='cpu-max'/>
   <flag name='memory-backend-file.x-use-canonical-path-for-ramblock-id'/>
index ddfc6a5bd35074fe1d37953217407de3fdf93c27..aaaf1d64f045c8c4fcf55fa52694d1cff7fa7534 100644 (file)
   <flag name='pvscsi'/>
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='virtio-pmem-pci'/>
index 531a8580aa6b60bd868a275ebb3a018788737a2e..b5e7b8274c80985aae1a18ab317a0b85761510fc 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='vhost-user-blk'/>
index 12f4e9460571a724ca54573408e15bfd97f1be60..3438fc14bbb76bf4b4be8dfd6350a3d9f6a3432f 100644 (file)
   <flag name='pvscsi'/>
   <flag name='spapr-tpm-proxy'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='vhost-user-blk'/>
index fc69cbd355c9cb413841763e4b73adcc4a41745a..fa67a21ee8d3a59b77769337d678f4c1507ddf59 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='vhost-user-blk'/>
index ba8fdeea7bde6d24aeca1ae25fb15ff1b81a5059..6a82e24659af9809e2b5367b55f9a8a2c85a415a 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='dc390'/>
   <flag name='am53c974'/>
   <flag name='virtio-pmem-pci'/>
index d0b615aec4750a443dfa0a3dfc3936ffa19f2be4..58cd77585cd413037c3d5d377f432151567ab411 100644 (file)
@@ -63,7 +63,6 @@
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='netdev.vhost-vdpa'/>
   <flag name='ncr53c90'/>
   <flag name='memory-backend-file.x-use-canonical-path-for-ramblock-id'/>
index f98583bc13097cc3419ea63dd4f3fcf37165c68b..6616a6bf1596dcd8e03f6d39fc0f4ca256248ae1 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='netdev.vhost-vdpa'/>
index 149423200fb72a7cea6f302b2a2ce3c1c9cee6b5..ffc66a8593a8064bb2cb677fcfb4c13775c726a7 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 6ab9b79560d77a9d922f738852c2a56d1c20c6e2..4f75dc8aadeec55e3da71d153dd809fa7d452e03 100644 (file)
   <flag name='pvscsi'/>
   <flag name='spapr-tpm-proxy'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 96d7630cc38945b4772d4a20b26310c40a21d606..2e3fcd2e3923d0bfdcc169ada9dd97c158499078 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index c9c1c0030c38997ed0b81e6f6d5fceaa2d4d8f0c..22c75094ddd097a94998f9061d5ffe5fcd13e738 100644 (file)
   <flag name='tcg'/>
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
   <flag name='netdev.vhost-vdpa'/>
index 255e2807cdb08900ed1b5d8447873d8f18efefae..add8c94704f0339325b311557270c59d657cd7ea 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index e0b0ad743b3fb7a17dcc5fadd68ab98b51098e56..79ea999de3b8377be460def91ba269bfbe6c7ec4 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 49f77d8a152a5b45217e03ad3ebbdd890ba6c206..a4a4e45eccd83db4defa6e99ba35fe6b8f08a4e7 100644 (file)
   <flag name='tcg'/>
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
   <flag name='netdev.vhost-vdpa'/>
index 40fefb5305ecf0dfc144e552e607f3356cd08f8a..95d7caa4ad01df9702e8dbc74e39ee7f08417e91 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index c6fa872f3e6289557328ffc67d1117769fdeef56..d5d98e72a643f9c4ef7a5b120a3d5efd10130b16 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 553914d4284b2c9014ff0f76f0477a882ce604b8..684227b087b032ef5cd11f5ac759d0c7b1daf154 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 17c2e28afd15ab1475c7760f5bc931ad6a6d6ae4..294e83309fb7071be88d486df954a5e9ecef7129 100644 (file)
   <flag name='pvscsi'/>
   <flag name='spapr-tpm-proxy'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
   <flag name='netdev.vhost-vdpa'/>
index 65a854f947bece95be121c78e7e39e377b3a2529..0c22ddb46816f978f2398b5499efcd279dd6fd94 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index c56d3333808222468a65ed4d6fec5c0ebb7c6d0e..e1a3113b6855ec44ac4cf9b11c5f6d30d6549c13 100644 (file)
   <flag name='virtio-blk-pci.scsi.default.disabled'/>
   <flag name='pvscsi'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 0aa4321c3cad2e5bfe09e858defbdcc62b7014d2..63c8e09ea9f128888b4cab128b702bb3aff9f095 100644 (file)
   <flag name='pvscsi'/>
   <flag name='spapr-tpm-proxy'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index 34eaa85b448205fb48b8aac59ebd99196c2c67a8..891f18aa3dffb2bd86a18114420c1ccdcbcc4b38 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index d571c123223785297d9195eb4515697d66512889..070c00fd290e787c9cc1174410023d99156fa618 100644 (file)
   <flag name='cpu.migratable'/>
   <flag name='intel-iommu.aw-bits'/>
   <flag name='numa.hmat'/>
-  <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
   <flag name='block-export-add'/>
index f1b3b78b1cedd79cd3c601e640b47807673fff44..bff8191552038eb6e968ddd622c278ee3c488d86 100644 (file)
@@ -885,7 +885,6 @@ testQemuInfoSetArgs(struct testQemuInfo *info,
 
     /* until removal of the flags is completed we force them also in tests */
     virQEMUCapsSet(info->args.fakeCaps, QEMU_CAPS_BLOCKDEV);
-    virQEMUCapsSet(info->args.fakeCaps, QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI);
 
     info->conf = conf;
     info->args.newargs = true;