vala: value_type of PointerIndirection expressions must not be owned

A member-access making the wrong assumption of a previous copy resulted
in a double free.

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1118

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 378768758a718eed2188338dfa7eb4d91c3a4068..bd8f62d7ef3dcad0d75c4237473f0ecf43b0b2a9 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -770,6 +770,7 @@ TESTS = \
        semantic/interface-prerequisite-multiple.test \
        semantic/literal-expression.test \
        semantic/localvariable-owned-to-unowned.test \
+       semantic/localvariable-var-pointer-initializer.vala \
        semantic/localvariable-var-static-access-instance-field.test \
        semantic/localvariable-var-static-access-instance-method.test \
        semantic/localvariable-var-static-access-instance-property.test \

diff --git a/tests/semantic/localvariable-var-pointer-initializer.vala b/tests/semantic/localvariable-var-pointer-initializer.vala
new file mode 100644 (file)
index 0000000..36ba40e
--- /dev/null
+++ b/tests/semantic/localvariable-var-pointer-initializer.vala
@@ -0,0 +1,11 @@
+struct Foo {
+       public string s;
+}
+
+void main () {
+       {
+               Foo foo = { "foo" };
+               var foo_p = &foo;
+               assert (foo_p.s == "foo");
+       }
+}

diff --git a/vala/valapointerindirection.vala b/vala/valapointerindirection.vala
index 3a126173f7c1b12b2bb3f82be53c3878e71c594e..cc183d953e426ec5f94db251893f1819c77dac09 100644 (file)
--- a/vala/valapointerindirection.vala
+++ b/vala/valapointerindirection.vala
@@ -98,6 +98,7 @@ public class Vala.PointerIndirection : Expression {
                                return false;
                        }
                        value_type = pointer_type.base_type;
+                       value_type.value_owned = false;
                } else {
                        error = true;
                        Report.error (source_reference, "Pointer indirection not supported for this expression");