i2c: Compare the return value of gpiod_get_direction against GPIO_LINE_DIRECTION_OUT

The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to
gpio consumers.h by breaking them out in a separate defs.h file.

Use this to validate the gpio direction instead of the hard-coded literal.

Signed-off-by: Nikola Z. Ivanov <zlatistiv@gmail.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 9c46147e3506d15d53b9b7d6b592709de56e41b9..a2132d70fb360da950df13bacd21073926bca129 100644 (file)
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -445,8 +445,7 @@ static int i2c_init_recovery(struct i2c_adapter *adap)
                bri->set_scl = set_scl_gpio_value;
                if (bri->sda_gpiod) {
                        bri->get_sda = get_sda_gpio_value;
-                       /* FIXME: add proper flag instead of '0' once available */
-                       if (gpiod_get_direction(bri->sda_gpiod) == 0)
+                       if (gpiod_get_direction(bri->sda_gpiod) == GPIO_LINE_DIRECTION_OUT)
                                bri->set_sda = set_sda_gpio_value;
                }
        } else if (bri->recover_bus == i2c_generic_scl_recovery) {