- Fix #574: Review fixes for it.

diff --git a/doc/Changelog b/doc/Changelog
index a8b304d91244b74b6b02d0f5176e45dd7590321b..e1bbb6a7e6bdeb26fc8c0b8b9f56ac2bec3d1ac6 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -4,6 +4,7 @@
        - Fix to make python module opt_list use opt_list_in.
        - Fix #574: unbound-checkconf reports fatal error if interface names
          are used as value for interfaces:
+       - Fix #574: Review fixes for it.
 
 15 November 2021: Tom
        - Improve EDNS option handling, now also works for synthesised

diff --git a/smallapp/unbound-checkconf.c b/smallapp/unbound-checkconf.c
index b88d010daf984136198ba93a2684e485b4ce9254..7dc9994f9df55fbfd9c197a90e8172adaa296969 100644 (file)
--- a/smallapp/unbound-checkconf.c
+++ b/smallapp/unbound-checkconf.c
@@ -54,6 +54,7 @@
 #include "iterator/iter_hints.h"
 #include "validator/validator.h"
 #include "services/localzone.h"
+#include "services/listen_dnsport.h"
 #include "services/view.h"
 #include "services/authzone.h"
 #include "respip/respip.h"
@@ -340,7 +341,9 @@ interfacechecks(struct config_file* cfg)
 
        if(cfg->num_ifs != 0) {
                resif = (char***)calloc(cfg->num_ifs, sizeof(char**));
+               if(!resif) fatal_exit("malloc failure");
                num_resif = (int*)calloc(cfg->num_ifs, sizeof(int*));
+               if(!num_resif) fatal_exit("malloc failure");
        }
        for(i=0; i<cfg->num_ifs; i++) {
                /* search for duplicates in IP or ifname arguments */