media: i2c: imx334: Fix runtime PM handling in remove function

pm_runtime_suspended() only checks the current runtime PM status and does
not modify it, making it ineffective in this context. This could result in
improper power management if the device remains active when removed.

This patch fixes the issue by introducing a check with
pm_runtime_status_suspended() to determine if the device is already
suspended. If it is not, it calls imx334_power_off() to power down the
device and then uses pm_runtime_set_suspended() to correctly update the
runtime PM status to suspended.

Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index e8422d2fadfd359d2c61538229c1494f72ef9f7a..2ede0787be14bdc2ff70a89eba8f18cbcd4fada2 100644 (file)
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -1328,7 +1328,10 @@ static void imx334_remove(struct i2c_client *client)
        v4l2_ctrl_handler_free(sd->ctrl_handler);
 
        pm_runtime_disable(&client->dev);
-       pm_runtime_suspended(&client->dev);
+       if (!pm_runtime_status_suspended(&client->dev)) {
+               imx334_power_off(&client->dev);
+               pm_runtime_set_suspended(&client->dev);
+       }
 
        mutex_destroy(&imx334->mutex);
 }