fix regression introduced by 1a65bdd2

noticed while reviewing hoganrobert/bug1138

diff --git a/changes/1a65bdd2-regression b/changes/1a65bdd2-regression
new file mode 100644 (file)
index 0000000..0a7436d
--- /dev/null
+++ b/changes/1a65bdd2-regression
@@ -0,0 +1,6 @@
+  o Minor bugfixes:
+    - Fix a regression introduced in 0.2.2.7-alpha that marked relays
+      down if a directory fetch fails and you've configured either
+      bridges or EntryNodes. The intent was to mark the relay as down
+      _unless_ you're using bridges or EntryNodes, since if you are
+      then you could quickly run out of entry points.

diff --git a/src/or/directory.c b/src/or/directory.c
index a3e575ac97fde0711cf5fdd719ce2d5e1142b454..e9fcb5ee178ddabd42052be1752e5251812d4981 100644 (file)
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -582,7 +582,7 @@ connection_dir_request_failed(dir_connection_t *conn)
   if (directory_conn_is_self_reachability_test(conn)) {
     return; /* this was a test fetch. don't retry. */
   }
-  if (entry_list_is_constrained(get_options()))
+  if (!entry_list_is_constrained(get_options()))
     router_set_status(conn->identity_digest, 0); /* don't try him again */
   if (conn->_base.purpose == DIR_PURPOSE_FETCH_V2_NETWORKSTATUS) {
     log_info(LD_DIR, "Giving up on directory server at '%s'; retrying",