qemu: Clear os.firmwareFeatures after autoselection

We already clear os.firmware, so it doesn't make sense to keep
the list of features around.

Moreover, our validation routines will reject an XML that
contains a list of firmware features but disables firmware
autoselection, so not clearing these means that the live XML
for a domain that uses feature-based autoselection can't be
fed back into libvirt.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index 175a4db21dd83d32153bad83814397f3984a96cb..572172bc75c9f7797802050eb37baa65784da52c 100644 (file)
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -1454,6 +1454,7 @@ qemuFirmwareFillDomain(virQEMUDriver *driver,
         goto cleanup;
 
     def->os.firmware = VIR_DOMAIN_OS_DEF_FIRMWARE_NONE;
+    VIR_FREE(def->os.firmwareFeatures);
 
     ret = 0;
  cleanup: