]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: stm32: Omit two variable reassignments in stm32_i2c_dma_request()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 20 Oct 2025 11:33:12 +0000 (13:33 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Mon, 27 Oct 2025 13:17:15 +0000 (14:17 +0100)
An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete two redundant variable reassignments.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/f7e0c023-d2d1-40ba-badb-74a7e9c23684@web.de
drivers/i2c/busses/i2c-stm32.c

index f84ec056e36dfedb2d72fe34c0b179604943708e..becf8977979f7318ed6c40fd2d4d173771c98788 100644 (file)
@@ -27,8 +27,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
        if (IS_ERR(dma->chan_tx)) {
                ret = PTR_ERR(dma->chan_tx);
                if (ret != -ENODEV)
-                       ret = dev_err_probe(dev, ret,
-                                           "can't request DMA tx channel\n");
+                       dev_err_probe(dev, ret, "can't request DMA tx channel\n");
+
                goto fail_al;
        }
 
@@ -48,8 +48,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
        if (IS_ERR(dma->chan_rx)) {
                ret = PTR_ERR(dma->chan_rx);
                if (ret != -ENODEV)
-                       ret = dev_err_probe(dev, ret,
-                                           "can't request DMA rx channel\n");
+                       dev_err_probe(dev, ret, "can't request DMA rx channel\n");
 
                goto fail_tx;
        }