]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: ipq9574: Add missing properties for cryptobam
authorStephan Gerhold <stephan.gerhold@linaro.org>
Wed, 12 Feb 2025 17:03:52 +0000 (18:03 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 13 Mar 2025 21:30:21 +0000 (16:30 -0500)
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].

Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.

[1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/
[2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/

Cc: stable@vger.kernel.org
Tested-by: Md Sadre Alam <quic_mdalam@quicinc.com>
Fixes: ffadc79ed99f ("arm64: dts: qcom: ipq9574: Enable crypto nodes")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Link: https://lore.kernel.org/r/20250212-bam-dma-fixes-v1-6-f560889e65d8@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/ipq9574.dtsi

index cac58352182e0eabaad6017e4ffe944aaa0ed19c..04bfe1f3fa7ae48fbb431e1449324c726c03434b 100644 (file)
                        interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
                        #dma-cells = <1>;
                        qcom,ee = <1>;
+                       qcom,num-ees = <4>;
+                       num-channels = <16>;
                        qcom,controlled-remotely;
                };