]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 600464: (CVE-2010-3172) [SECURITY] Content/Header injection due to non-random...
authorByron Jones <glob@glob.com.au>
Tue, 2 Nov 2010 23:23:50 +0000 (00:23 +0100)
committerFrédéric Buclin <LpSolit@gmail.com>
Tue, 2 Nov 2010 23:23:50 +0000 (00:23 +0100)
r=mkanat a=LpSolit

Bugzilla/CGI.pm

index 1799786d3398991b3c67847c3bac5c105480191a..2c32c5d611227db89eca8ca7b5ff526a9eef022f 100644 (file)
@@ -172,7 +172,8 @@ sub multipart_init {
     }
 
     # Set the MIME boundary and content-type
-    my $boundary = $param{'-boundary'} || '------- =_aaaaaaaaaa0';
+    my $boundary = $param{'-boundary'}
+        || '------- =_' . generate_random_password(16);
     delete $param{'-boundary'};
     $self->{'separator'} = "\r\n--$boundary\r\n";
     $self->{'final_separator'} = "\r\n--$boundary--\r\n";