]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: drv-net: Fix remote command checking in require_cmd()
authorGal Pressman <gal@nvidia.com>
Wed, 23 Jul 2025 13:54:53 +0000 (16:54 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 25 Jul 2025 01:52:00 +0000 (18:52 -0700)
The require_cmd() method was checking for command availability locally
even when remote=True was specified, due to a missing host parameter.

Fix by passing host=self.remote when checking remote command
availability, ensuring commands are verified on the correct host.

Fixes: f1e68a1a4a40 ("selftests: drv-net: add require_XYZ() helpers for validating env")
Reviewed-by: Nimrod Oren <noren@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20250723135454.649342-2-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/lib/py/env.py

index 3bccddf8cbc5a2be9640000791a8e5f196318933..1b8bd648048f74463da120fced579df86a5b8aa5 100644 (file)
@@ -259,7 +259,7 @@ class NetDrvEpEnv(NetDrvEnvBase):
             if not self._require_cmd(comm, "local"):
                 raise KsftSkipEx("Test requires command: " + comm)
         if remote:
-            if not self._require_cmd(comm, "remote"):
+            if not self._require_cmd(comm, "remote", host=self.remote):
                 raise KsftSkipEx("Test requires (remote) command: " + comm)
 
     def wait_hw_stats_settle(self):