load: distinguish if SOA serial is lower or incomparable in a warning log

diff --git a/src/knot/events/handlers/load.c b/src/knot/events/handlers/load.c
index 8c83285905bb5afcaeaeb8bfebe5adaca8e4651f..8b15625057e588e9f042de3ba391ba343e3f9ee8 100644 (file)
--- a/src/knot/events/handlers/load.c
+++ b/src/knot/events/handlers/load.c
@@ -240,7 +240,11 @@ load_end:
                        log_zone_warning(zone->name, "zone file changed without SOA serial update");
                        break;
                case KNOT_ERANGE:
-                       log_zone_warning(zone->name, "zone file changed, but SOA serial decreased");
+                       if (serial_compare(zone->zonefile.serial, zone_contents_serial(zone->contents)) == SERIAL_INCOMPARABLE) {
+                               log_zone_warning(zone->name, "zone file changed with incomparable SOA serial");
+                       } else {
+                               log_zone_warning(zone->name, "zone file changed with decreased SOA serial");
+                       }
                        break;
                }
                goto cleanup;

diff --git a/src/knot/zone/serial.h b/src/knot/zone/serial.h
index 18e24b1284fc27585a202e9be9a0c7e7cabffdfc..effb1c63995b7c9c1936c3ff8cd12b8f35fe4432 100644 (file)
--- a/src/knot/zone/serial.h
+++ b/src/knot/zone/serial.h
@@ -1,4 +1,4 @@
-/*  Copyright (C) 2019 CZ.NIC, z.s.p.o. <knot-dns@labs.nic.cz>
+/*  Copyright (C) 2022 CZ.NIC, z.s.p.o. <knot-dns@labs.nic.cz>
 
     This program is free software: you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -19,6 +19,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 
+#define SERIAL_MAX_INCREMENT 2147483647
+
 /*!
  * \brief result of serial comparison. LOWER means that the first serial is lower that the second.
  *