]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ata: libata: Fix NCQ Non-Data log not supported print
authorNiklas Cassel <cassel@kernel.org>
Mon, 17 Mar 2025 11:17:55 +0000 (12:17 +0100)
committerNiklas Cassel <cassel@kernel.org>
Tue, 18 Mar 2025 08:03:12 +0000 (09:03 +0100)
Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ
Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() -
which checks for NCQ Non-Data Log (Log Address 12h), uses the same
print when the log is not supported:

  "NCQ Send/Recv Log not supported"

This seems like a copy paste error, since NCQ Non-Data Log is actually
a separate log.

Fix the print to reference the correct log.

Fixes: 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20250317111754.1666084-2-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/libata-core.c

index 193fc3942fd3a9035fd510c73b5d639bb6b50ea1..e17e16706db70c882fef9a279e97df625fbd3cd1 100644 (file)
@@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
 
        if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
                ata_dev_warn(dev,
-                            "NCQ Send/Recv Log not supported\n");
+                            "NCQ Non-Data Log not supported\n");
                return;
        }
        err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,