]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: tda1997x: Call of_node_put(ep) only once in tda1997x_parse_dt()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 3 Oct 2024 19:38:45 +0000 (21:38 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 6 Mar 2025 16:28:28 +0000 (17:28 +0100)
An of_node_put(ep) call was immediately used after a return value check
for a v4l2_fwnode_endpoint_parse() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/tda1997x.c

index 3b7e5ff5b010b5525dcc784c92dd0d5b7b544f64..959590afc80fc3959a09f5fedeb4c9dd5356514a 100644 (file)
@@ -2315,11 +2315,10 @@ static int tda1997x_parse_dt(struct tda1997x_state *state)
                return -EINVAL;
 
        ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &bus_cfg);
-       if (ret) {
-               of_node_put(ep);
-               return ret;
-       }
        of_node_put(ep);
+       if (ret)
+               return ret;
+
        pdata->vidout_bus_type = bus_cfg.bus_type;
 
        /* polarity of HS/VS/DE */