codegen/vala: Improve check for GLib.Source derived classes

diff --git a/codegen/valaccodemethodcallmodule.vala b/codegen/valaccodemethodcallmodule.vala
index 95b4618c6633d147c2897c70eb075a34350c7cdb..bbd08e00f797a6430e83c1f24cde89b56652202e 100644 (file)
--- a/codegen/valaccodemethodcallmodule.vala
+++ b/codegen/valaccodemethodcallmodule.vala
@@ -184,7 +184,7 @@ public class Vala.CCodeMethodCallModule : CCodeAssignmentModule {
                                                type_param_index++;
                                        }
                                }
-                       } else if (current_class.base_class == gsource_type) {
+                       } else if (current_class.is_subtype_of (gsource_type)) {
                                // g_source_new
 
                                string class_prefix = get_ccode_lower_case_name (current_class);
@@ -952,7 +952,7 @@ public class Vala.CCodeMethodCallModule : CCodeAssignmentModule {
                        }
                }
 
-               if (m is CreationMethod && m.parent_symbol is Class && ((current_class.is_compact && current_class.base_class != null) || current_class.base_class == gsource_type)) {
+               if (m is CreationMethod && m.parent_symbol is Class && ((current_class.is_compact && current_class.base_class != null) || current_class.is_subtype_of (gsource_type))) {
                        var cinitcall = new CCodeFunctionCall (new CCodeIdentifier ("%s_instance_init".printf (get_ccode_lower_case_name (current_class, null))));
                        cinitcall.add_argument (get_this_cexpression ());
                        if (!current_class.is_compact) {

diff --git a/codegen/valagtypemodule.vala b/codegen/valagtypemodule.vala
index 63d27ea294bbcb2e60f8f941d7702df3926033e8..4ea80f8450eec2b947f0b29bd1071fe9db625ac4 100644 (file)
--- a/codegen/valagtypemodule.vala
+++ b/codegen/valagtypemodule.vala
@@ -63,7 +63,7 @@ public class Vala.GTypeModule : GErrorModule {
 
                bool is_gtypeinstance = !cl.is_compact;
                bool is_fundamental = is_gtypeinstance && cl.base_class == null;
-               bool is_gsource = cl.base_class == gsource_type;
+               bool is_gsource = cl.is_subtype_of (gsource_type);
 
                if (is_gtypeinstance) {
                        decl_space.add_include ("glib-object.h");
@@ -656,7 +656,7 @@ public class Vala.GTypeModule : GErrorModule {
                        begin_class_finalize_function (cl);
                        begin_finalize_function (cl);
                } else {
-                       if (cl.is_compact || cl.base_class == null || cl.base_class == gsource_type) {
+                       if (cl.is_compact || cl.base_class == null || cl.is_subtype_of (gsource_type)) {
                                begin_instance_init_function (cl);
                                begin_finalize_function (cl);
                        }
@@ -796,7 +796,7 @@ public class Vala.GTypeModule : GErrorModule {
                                cfile.add_function (unref_fun);
                        }
                } else {
-                       if (cl.is_compact || cl.base_class == null || cl.base_class == gsource_type) {
+                       if (cl.is_compact || cl.base_class == null || cl.is_subtype_of (gsource_type)) {
                                add_instance_init_function (cl);
                                add_finalize_function (cl);
                        }
@@ -1638,7 +1638,7 @@ public class Vala.GTypeModule : GErrorModule {
 
                push_function (func);
 
-               bool is_gsource = cl.base_class == gsource_type;
+               bool is_gsource = cl.is_subtype_of (gsource_type);
 
                if (cl.is_compact) {
                        // Add declaration, since the instance_init function is explicitly called
@@ -1784,7 +1784,7 @@ public class Vala.GTypeModule : GErrorModule {
        private void begin_finalize_function (Class cl) {
                push_context (instance_finalize_context);
 
-               bool is_gsource = cl.base_class == gsource_type;
+               bool is_gsource = cl.is_subtype_of (gsource_type);
 
                if (!cl.is_compact || is_gsource) {
                        var fundamental_class = cl;
@@ -1878,7 +1878,7 @@ public class Vala.GTypeModule : GErrorModule {
                        pop_context ();
 
                        cfile.add_function (instance_finalize_context.ccode);
-               } else if (cl.base_class == gsource_type) {
+               } else if (cl.is_subtype_of (gsource_type)) {
                        cfile.add_function (instance_finalize_context.ccode);
                }
        }

diff --git a/vala/valaclass.vala b/vala/valaclass.vala
index 88339dec18108f0ed0383de917244a8d3101805d..b6bd6377318f55cb5e3c2dd97af74eb44ddd7a18 100644 (file)
--- a/vala/valaclass.vala
+++ b/vala/valaclass.vala
@@ -708,7 +708,7 @@ public class Vala.Class : ObjectTypeSymbol {
                                }
                        }
 
-                       if (!external && !external_package && base_class != null && base_class != context.analyzer.gsource_type) {
+                       if (!external && !external_package && base_class != null && !base_class.is_subtype_of (context.analyzer.gsource_type)) {
                                foreach (Field f in get_fields ()) {
                                        if (f.binding == MemberBinding.INSTANCE) {
                                                error = true;