]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: tegra: add OF node when logging OF parsing errors
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 26 Sep 2023 10:39:38 +0000 (12:39 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 27 Sep 2023 08:54:59 +0000 (10:54 +0200)
These errors are not quite clear without also logging they device tree node
being parsed, especially when the pinmux node has lots of subnodes. Adding
the node name helps a lot in finding the node that triggers the error.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20230926103938.334055-1-luca.ceresoli@bootlin.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/tegra/pinctrl-tegra.c

index cfeda5b3e04821bfffae995eb00291ba53dcc1ef..9e8a0e6e5f414203da9825487cb9d6cf5abfda52 100644 (file)
@@ -121,7 +121,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
                /* EINVAL=missing, which is fine since it's optional */
                if (ret != -EINVAL)
                        dev_err(dev,
-                               "could not parse property nvidia,function\n");
+                               "%pOF: could not parse property nvidia,function\n", np);
                function = NULL;
        }
 
@@ -135,8 +135,8 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
                                goto exit;
                /* EINVAL=missing, which is fine since it's optional */
                } else if (ret != -EINVAL) {
-                       dev_err(dev, "could not parse property %s\n",
-                               cfg_params[i].property);
+                       dev_err(dev, "%pOF: could not parse property %s\n",
+                               np, cfg_params[i].property);
                }
        }
 
@@ -147,7 +147,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
                reserve++;
        ret = of_property_count_strings(np, "nvidia,pins");
        if (ret < 0) {
-               dev_err(dev, "could not parse property nvidia,pins\n");
+               dev_err(dev, "%pOF: could not parse property nvidia,pins\n", np);
                goto exit;
        }
        reserve *= ret;